Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2746 Incorrect phosphorus valence #2754

Merged
merged 2 commits into from
Feb 18, 2025
Merged

#2746 Incorrect phosphorus valence #2754

merged 2 commits into from
Feb 18, 2025

Conversation

jblack-mestre
Copy link
Contributor

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@AlexanderSavelyev AlexanderSavelyev linked an issue Feb 10, 2025 that may be closed by this pull request
Incorrect phosphorus valence #2746
Closed
AliaksandrDziarkach
AliaksandrDziarkach approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@AliaksandrDziarkach AliaksandrDziarkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add/remove bond is safe because molecule cloned at the start of this function - line 813

LGTM

@AlexanderSavelyev AlexanderSavelyev merged commit 621a350 into epam:master Feb 18, 2025
57 checks passed
@AlexanderSavelyev
Copy link
Collaborator

thanks for the PR!

@jblack-mestre
Copy link
Contributor Author

Thanks for merging!

@jblack-mestre jblack-mestre deleted the 2746_phosphorus_valence branch February 18, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliaksandrDziarkach AliaksandrDziarkach AliaksandrDziarkach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect phosphorus valence
3 participants
@jblack-mestre @AlexanderSavelyev @AliaksandrDziarkach